New "Video | Shorts" tab strip on the main page. The existing Video tab and
its render pipeline are unchanged; Shorts is a new, independent workflow
sharing the same render-progress/log/output controls.
- Services/ShortsPipeline.cs: C# port of amigadb-short.sh rather than
shelling out to bash — end users on plain Windows don't have bash/WSL, and
shipping this as a native part of the app keeps distribution self-contained.
All 19 visual style filtergraphs (brand, pixel, mirror, crop, workbench,
blur, crt, copper, stars, grid, tiles, scan, starfield, plasma,
rasterbars, vhs, monitor, split, spectrum) are copied verbatim from the
bash heredocs. Per explicit decision, kept parity with the script's actual
behavior where the brand-style HOOK_BOX_Y/INFO_BOX_Y/font-size variables
are computed but never actually used in the final filter (dead code in
the original) rather than "fixing" it and changing rendered output.
Reuses ToolExtractor/MediaProbe/ProcessRunner exactly as RenderPipeline
does, so FFmpeg resolution and NVENC fallback behave identically.
- Models/ShortSettings.cs: job parameters + ShortStyle enum.
- AppSettings gains sticky Shorts defaults (style, hook, website, font,
background image, CRF, preset) alongside the existing Video defaults.
- MainPage: Video/Shorts tab buttons toggle two content panels; the
background-image field auto-hides for non-brand styles; font field
defaults to the first bold system font found (Segoe UI Bold, Segoe UI
Semibold, Arial Bold, Calibri Bold); blank output path is auto-derived
from the input filename and style, matching the script's default.
- 13 new unit tests (escaping order, meta-line joining, validation,
every style producing a non-empty filter, the drawtext trailer's timing
gates). Full run is 72/72 passing.
- Fixed a bug caught during manual testing: MainPage.Resources["PrimaryButtonStyle"]
looked in the Page's own (empty) resource dictionary instead of
Application.Current.Resources, throwing on every tab switch.
Verified end-to-end: rendered a real Short from an existing video through
the actual running app (not just unit tests) and inspected extracted
frames — hook/title/meta/website text overlays appear and disappear at the
correct timestamps with correct styling.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Implements the suggestions from the last review pass:
- Add AmiReel.Tests (MSTest), covering the pure logic in Models/ and
Services/: SupportedVideoFormats, AppSettings normalization,
UserFacingErrors.Summarize, the new FfmpegProgressParser/
FfmpegOutputFilter, RenderPipeline.Validate, BuildProgressMessage, and
MoveSourceVideos. 59 tests, all passing. UI code-behind and anything that
spawns an actual FFmpeg process are left to manual/integration testing.
Exclude AmiReel.Tests\**\*.cs from AmiReel.csproj's default item glob —
it's a subfolder of the app project now, so without the exclude the app
itself was compiling the MSTest-only test files.
- Extract the FFmpeg version/library-banner boilerplate list that
ProcessRunner (live log filter) and UserFacingErrors (error summarizer)
had each duplicated into a shared FfmpegOutputFilter.IsBoilerplateLine;
each caller keeps its own remaining context-specific checks on top.
Also extract ProcessRunner's line-parsing regexes into a standalone
FfmpegProgressParser so it's directly unit-testable without spawning a
process.
- Convert AppSettings and RenderSettings from positional record
constructors to named `required` init properties. Both records had
runs of same-typed consecutive parameters (three string timing fields
in AppSettings; three doubles then five ints in RenderSettings) that a
positional constructor would let get silently transposed at a call site
without the compiler catching it. Update the two call sites
(MainPage.xaml.cs) to object-initializer syntax.
- Add Properties/AssemblyInfo.cs with InternalsVisibleTo("AmiReel.Tests")
and make Validate/BuildProgressMessage/IsNoise internal so tests can
reach them directly instead of only through process-spawning entry
points.
- README: document `dotnet test`, and note that Package.appxmanifest's
Identity is a local-dev placeholder that needs a real publisher/cert
before MSIX distribution.
Verified: dotnet build (solution + test project) is 0 warnings/errors,
dotnet test is 59/59 passing, and the app still launches unchanged.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
klevze