klevze/vision
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Preserve CLIP client errors through qdrant

Browse Source
This commit is contained in:
klevze
2026-08-29 09:19:38 +02:00
parent d5faa49c47
commit 32ddf70e2f
4 changed files with 122 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_clip_observability.py
+18 -6
View File
@@ -62,12 +62,12 @@ class ClipObservabilityTests(unittest.TestCase):
def tearDown(self):
self.module.logger.removeHandler(self.handler)
def assert_failed_embed(self, error):
def assert_failed_embed(self, error, expected_status):
url = "https://user:[email protected]/images/art.webp?token=SECRET&sig=VALUE"
with patch.object(self.module, "fetch_url_bytes", side_effect=error):
with self.assertRaises(self.module.HTTPException) as raised:
self.module.embed(self.module.EmbedRequest(url=url))
self.assertEqual(raised.exception.status_code, 400)
self.assertEqual(raised.exception.status_code, expected_status)
self.assertEqual(len(self.records), 1)
line = self.records[0]
self.assertIn("event='clip_image_fetch_failed'", line)
@@ -79,20 +79,20 @@ class ClipObservabilityTests(unittest.TestCase):
self.assertNotIn("Authorization", line)
def test_read_timeout_is_logged_and_remains_400(self):
self.assert_failed_embed(ImageLoadError("read failed", category="read_timeout", stage="fetch", original_exception_class="ReadTimeout"))
self.assert_failed_embed(ImageLoadError("read failed", category="read_timeout", stage="fetch", original_exception_class="ReadTimeout"), 502)
self.assertIn("error_type='read_timeout'", self.records[0])
def test_dns_failure_is_logged(self):
self.assert_failed_embed(ImageLoadError("dns failed", category="dns_failure", stage="validate", original_exception_class="gaierror"))
self.assert_failed_embed(ImageLoadError("dns failed", category="dns_failure", stage="validate", original_exception_class="gaierror"), 502)
self.assertIn("error_type='dns_failure'", self.records[0])
def test_invalid_content_type_is_logged(self):
self.assert_failed_embed(ImageLoadError("not an image", category="invalid_content_type", stage="fetch", original_exception_class="ImageLoadError", metadata={"content_type": "text/html"}))
self.assert_failed_embed(ImageLoadError("not an image", category="invalid_content_type", stage="fetch", original_exception_class="ImageLoadError", metadata={"content_type": "text/html"}), 400)
self.assertIn("error_type='invalid_content_type'", self.records[0])
self.assertIn("content_type='text/html'", self.records[0])
def test_decode_failure_is_logged(self):
self.assert_failed_embed(ImageLoadError("decode failed", category="decode_failure", stage="decode", original_exception_class="UnidentifiedImageError"))
self.assert_failed_embed(ImageLoadError("decode failed", category="decode_failure", stage="decode", original_exception_class="UnidentifiedImageError"), 400)
self.assertIn("stage='decode'", self.records[0])
def test_success_emits_no_failure_warning(self):
@@ -101,6 +101,18 @@ class ClipObservabilityTests(unittest.TestCase):
self.assertEqual(response, {"vector": [0.1]})
self.assertEqual(self.records, [])
def test_permanent_categories_remain_400(self):
for category in ("invalid_scheme", "missing_hostname", "blocked_address", "image_too_large", "remote_http_4xx"):
with self.subTest(category=category):
self.records.clear()
self.assert_failed_embed(ImageLoadError("rejected", category=category), 400)
def test_transient_and_unknown_categories_are_502(self):
for category in ("connect_timeout", "connection_error", "remote_http_5xx", "fetch_failure", "unknown"):
with self.subTest(category=category):
self.records.clear()
self.assert_failed_embed(ImageLoadError("upstream failure", category=category), 502)
if __name__ == "__main__":
unittest.main()