klevze/SkinbaseNova
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: ship creator journey v2 and profile updates

Browse Source
This commit is contained in:
Gregor Klevže
2026-04-12 21:42:07 +02:00
parent a2457f4e49
commit d5cff21ea2
335 changed files with 20147 additions and 1545 deletions
Download Patch File Download Diff File Expand all files Collapse all files

206
tests/Feature/ArtworkAwardTest.php
View File

@@ -6,11 +6,22 @@ use App\Models\Artwork;
use App\Models\ArtworkAward;
use App\Models\ArtworkAwardStat;
use App\Models\User;
use App\Jobs\IndexArtworkJob;
use App\Services\HomepageService;
use App\Services\ArtworkAwardService;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Foundation\Http\Middleware\VerifyCsrfToken;
use Illuminate\Support\Facades\Config;
use Illuminate\Support\Facades\Cache;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Queue;
uses(RefreshDatabase::class);
beforeEach(function () {
$this->withoutMiddleware(VerifyCsrfToken::class);
});
// ---------------------------------------------------------------------------
// Helper
// ---------------------------------------------------------------------------
@@ -35,7 +46,7 @@ test('user can award an artwork', function () {
$award = $service->award($artwork, $user, 'gold');
expect($award->medal)->toBe('gold')
->and($award->weight)->toBe(3)
->and($award->weight)->toBe(5)
->and($award->artwork_id)->toBe($artwork->id)
->and($award->user_id)->toBe($user->id);
});
@@ -58,7 +69,9 @@ test('stats are recalculated after awarding', function () {
expect($stat->gold_count)->toBe(1)
->and($stat->silver_count)->toBe(1)
->and($stat->bronze_count)->toBe(1)
->and($stat->score_total)->toBe(6); // 3+2+1
->and($stat->score_total)->toBe(9)
->and($stat->score_7d)->toBe(9)
->and($stat->score_30d)->toBe(9);
});
test('duplicate award is rejected', function () {
@@ -106,7 +119,7 @@ test('user can remove their award', function () {
->and($stat->score_total)->toBe(0);
});
test('score formula is gold×3 + silver×2 + bronze×1', function () {
test('score formula is gold×5 + silver×3 + bronze×1', function () {
$service = app(ArtworkAwardService::class);
$owner = User::factory()->create();
$artwork = makePublishedArtwork(['user_id' => $owner->id]);
@@ -116,7 +129,48 @@ test('score formula is gold×3 + silver×2 + bronze×1', function () {
}
$stat = ArtworkAwardStat::find($artwork->id);
expect($stat->score_total)->toBe((2 * 3) + (1 * 2) + (1 * 1)); // 9
expect($stat->score_total)->toBe((2 * 5) + (1 * 3) + (1 * 1));
});
test('recent medal scores only count medals inside the rolling windows', function () {
$owner = User::factory()->create();
$artwork = makePublishedArtwork(['user_id' => $owner->id]);
$service = app(ArtworkAwardService::class);
DB::table('artwork_medals')->insert([
[
'artwork_id' => $artwork->id,
'user_id' => User::factory()->create()->id,
'medal_type' => 'gold',
'weight' => 5,
'created_at' => now()->subDays(2),
'updated_at' => now()->subDays(2),
],
[
'artwork_id' => $artwork->id,
'user_id' => User::factory()->create()->id,
'medal_type' => 'silver',
'weight' => 3,
'created_at' => now()->subDays(10),
'updated_at' => now()->subDays(10),
],
[
'artwork_id' => $artwork->id,
'user_id' => User::factory()->create()->id,
'medal_type' => 'bronze',
'weight' => 1,
'created_at' => now()->subDays(40),
'updated_at' => now()->subDays(40),
],
]);
$service->recalcStats($artwork->id);
$stat = ArtworkAwardStat::find($artwork->id);
expect($stat->score_total)->toBe(9)
->and($stat->score_7d)->toBe(5)
->and($stat->score_30d)->toBe(8);
});
// ---------------------------------------------------------------------------
@@ -141,6 +195,55 @@ test('POST /api/artworks/{id}/award — authenticated user can award', function
->assertJsonPath('viewer_award', 'gold');
});
test('POST /api/artworks/{id}/medal upserts medal state and returns fresh stats', function () {
$user = User::factory()->create(['created_at' => now()->subDays(30)]);
$artwork = makePublishedArtwork(['user_id' => User::factory()->create()->id]);
$this->actingAs($user)
->postJson("/api/artworks/{$artwork->id}/medal", ['medal_type' => 'gold'])
->assertCreated()
->assertJsonPath('medals.gold', 1)
->assertJsonPath('medals.score', 5)
->assertJsonPath('current_user_medal', 'gold');
$this->actingAs($user)
->postJson("/api/artworks/{$artwork->id}/medal", ['medal_type' => 'silver'])
->assertOk()
->assertJsonPath('medals.gold', 0)
->assertJsonPath('medals.silver', 1)
->assertJsonPath('medals.score', 3)
->assertJsonPath('current_user_medal', 'silver');
expect(ArtworkAward::query()
->where('artwork_id', $artwork->id)
->where('user_id', $user->id)
->count())->toBe(1);
});
test('DELETE /api/artworks/{id}/medal removes the current medal idempotently', function () {
$user = User::factory()->create(['created_at' => now()->subDays(30)]);
$artwork = makePublishedArtwork(['user_id' => User::factory()->create()->id]);
ArtworkAward::create([
'artwork_id' => $artwork->id,
'user_id' => $user->id,
'medal' => 'silver',
'weight' => 3,
]);
$this->actingAs($user)
->deleteJson("/api/artworks/{$artwork->id}/medal")
->assertOk()
->assertJsonPath('current_user_medal', null)
->assertJsonPath('medals.score', 0);
$this->actingAs($user)
->deleteJson("/api/artworks/{$artwork->id}/medal")
->assertOk()
->assertJsonPath('current_user_medal', null)
->assertJsonPath('medals.score', 0);
});
test('POST /api/artworks/{id}/award — duplicate is rejected with 422', function () {
$user = User::factory()->create(['created_at' => now()->subDays(30)]);
$artwork = makePublishedArtwork(['user_id' => User::factory()->create()->id]);
@@ -149,7 +252,7 @@ test('POST /api/artworks/{id}/award — duplicate is rejected with 422', functio
'artwork_id' => $artwork->id,
'user_id' => $user->id,
'medal' => 'gold',
'weight' => 3,
'weight' => 5,
]);
$this->actingAs($user)
@@ -165,7 +268,7 @@ test('PUT /api/artworks/{id}/award — user can change their award', function ()
'artwork_id' => $artwork->id,
'user_id' => $user->id,
'medal' => 'gold',
'weight' => 3,
'weight' => 5,
]);
$this->actingAs($user)
@@ -182,7 +285,7 @@ test('DELETE /api/artworks/{id}/award — user can remove their award', function
'artwork_id' => $artwork->id,
'user_id' => $user->id,
'medal' => 'silver',
'weight' => 2,
'weight' => 3,
]);
$this->actingAs($user)
@@ -202,7 +305,10 @@ test('GET /api/artworks/{id}/awards — returns stats publicly', function () {
'gold_count' => 2,
'silver_count' => 1,
'bronze_count' => 3,
'score_total' => 11,
'score_total' => 16,
'score_7d' => 8,
'score_30d' => 12,
'created_at' => now(),
'updated_at' => now(),
]);
@@ -211,7 +317,9 @@ test('GET /api/artworks/{id}/awards — returns stats publicly', function () {
->assertJsonPath('awards.gold', 2)
->assertJsonPath('awards.silver', 1)
->assertJsonPath('awards.bronze', 3)
->assertJsonPath('awards.score', 11);
->assertJsonPath('awards.score', 16)
->assertJsonPath('awards.score_7d', 8)
->assertJsonPath('awards.score_30d', 12);
});
test('observer recalculates stats when award is created', function () {
@@ -222,25 +330,36 @@ test('observer recalculates stats when award is created', function () {
'artwork_id' => $artwork->id,
'user_id' => $user->id,
'medal' => 'gold',
'weight' => 3,
'weight' => 5,
]);
$stat = ArtworkAwardStat::find($artwork->id);
expect($stat->gold_count)->toBe(1)
->and($stat->score_total)->toBe(3);
->and($stat->score_total)->toBe(5);
});
// ---------------------------------------------------------------------------
// Abuse / security tests
// ---------------------------------------------------------------------------
test('new account (< 7 days) is rejected with 403', function () {
test('new account below minimum age is rejected with 403', function () {
$user = User::factory()->create(['created_at' => now()->subHours(12)]);
$artwork = makePublishedArtwork(['user_id' => User::factory()->create()->id]);
$this->actingAs($user)
->postJson("/api/artworks/{$artwork->id}/award", ['medal' => 'gold'])
->assertForbidden();
->assertForbidden()
->assertJsonPath('message', 'Your account must be at least 24 hours old before giving medals.');
});
test('unverified account is rejected from the medal endpoint with a clear reason', function () {
$user = User::factory()->unverified()->create(['created_at' => now()->subDays(30)]);
$artwork = makePublishedArtwork(['user_id' => User::factory()->create()->id]);
$this->actingAs($user)
->postJson("/api/artworks/{$artwork->id}/medal", ['medal_type' => 'gold'])
->assertForbidden()
->assertJsonPath('message', 'Verify your email address before giving medals.');
});
test('user cannot award their own artwork', function () {
@@ -249,44 +368,67 @@ test('user cannot award their own artwork', function () {
$this->actingAs($user)
->postJson("/api/artworks/{$artwork->id}/award", ['medal' => 'gold'])
->assertForbidden();
->assertForbidden()
->assertJsonPath('message', 'You cannot medal your own artwork.');
});
// ---------------------------------------------------------------------------
// Meilisearch sync test
// ---------------------------------------------------------------------------
test('syncToSearch is called when an award is given', function () {
$service = $this->partialMock(
\App\Services\ArtworkAwardService::class,
function (\Mockery\MockInterface $mock) {
$mock->shouldReceive('syncToSearch')->atLeast()->once();
}
);
test('awarding a medal dispatches artwork reindexing', function () {
Queue::fake();
$service = app(ArtworkAwardService::class);
$user = User::factory()->create();
$artwork = makePublishedArtwork(['user_id' => User::factory()->create()->id]);
$service->award($artwork, $user, 'silver');
Queue::assertPushed(IndexArtworkJob::class);
});
test('syncToSearch is called when an award is removed', function () {
$service = $this->partialMock(
\App\Services\ArtworkAwardService::class,
function (\Mockery\MockInterface $mock) {
$mock->shouldReceive('syncToSearch')->atLeast()->once();
}
);
test('removing a medal dispatches artwork reindexing', function () {
Queue::fake();
$service = app(ArtworkAwardService::class);
$user = User::factory()->create();
$artwork = makePublishedArtwork(['user_id' => User::factory()->create()->id]);
ArtworkAward::create([
DB::table('artwork_medals')->insert([
'artwork_id' => $artwork->id,
'user_id' => $user->id,
'medal' => 'gold',
'weight' => 3,
'user_id' => $user->id,
'medal_type' => 'gold',
'weight' => 5,
'created_at' => now(),
'updated_at' => now(),
]);
$service->removeAward($artwork, $user);
Queue::assertPushed(IndexArtworkJob::class);
});
test('cache invalidation occurs after medal updates', function () {
$homepage = app(HomepageService::class);
$service = app(ArtworkAwardService::class);
$user = User::factory()->create(['created_at' => now()->subDays(30), 'email_verified_at' => now()]);
$artwork = makePublishedArtwork(['user_id' => User::factory()->create()->id]);
$guestPayloadKey = 'homepage.payload.guest.test.' . $artwork->id;
Config::set('homepage.guest_payload_key', $guestPayloadKey);
Cache::put('homepage.hero', ['stale' => true], 600);
Cache::put('homepage.community-favorites.8', ['stale' => true], 600);
Cache::put('homepage.hall-of-fame.8', ['stale' => true], 600);
Cache::store($homepage->guestPayloadCacheStoreName())->put($guestPayloadKey, ['stale' => true], 600);
$service->award($artwork, $user, 'gold');
expect(Cache::get('homepage.hero'))->toBeNull()
->and(Cache::get('homepage.community-favorites.8'))->toBeNull()
->and(Cache::get('homepage.hall-of-fame.8'))->toBeNull()
->and(Cache::store($homepage->guestPayloadCacheStoreName())->get($guestPayloadKey))->toBeNull();
});