Optimize academy

app/Jobs/RecComputeSimilarHybridJob.php

@@ -9,6 +9,7 @@ use App\Models\RecArtworkRec;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Foundation\Bus\Dispatchable;
+use Illuminate\Queue\Middleware\WithoutOverlapping;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Support\Facades\DB;
@@ -25,7 +26,10 @@ final class RecComputeSimilarHybridJob implements ShouldQueue
 {
     use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
 
-    public int $tries   = 2;
+    // This recompute is idempotent and already guards per-artwork execution.
+    // Keep retries to a minimum so transient failures do not turn into
+    // Horizon's max-attempt exception noise.
+    public int $tries   = 1;
     public int $timeout = 900;
 
     public function __construct(
@@ -38,6 +42,24 @@ final class RecComputeSimilarHybridJob implements ShouldQueue
         }
     }
 
+    /**
+     * @return array<int, object>
+     */
+    public function middleware(): array
+    {
+        if ($this->artworkId === null) {
+            return [];
+        }
+
+        return [
+            // Many artwork lifecycle events can queue this same recompute burstily.
+            // Keep only one in flight per artwork and drop overlapping duplicates.
+            (new WithoutOverlapping('rec-similar-hybrid:'.$this->artworkId))
+                ->expireAfter($this->timeout + 60)
+                ->dontRelease(),
+        ];
+    }
+
     public function handle(): void
     {
         $modelVersion   = (string) config('recommendations.similarity.model_version', 'sim_v1');
@@ -50,26 +72,90 @@ final class RecComputeSimilarHybridJob implements ShouldQueue
             ? (array) config('recommendations.similarity.weights_with_vector')
             : (array) config('recommendations.similarity.weights_without_vector');
 
-        $query = Artwork::query()->public()->published()->select('id', 'user_id');
-
         if ($this->artworkId !== null) {
-            $query->where('id', $this->artworkId);
+            $artwork = Artwork::query()
+                ->public()
+                ->published()
+                ->select('id', 'user_id')
+                ->find($this->artworkId);
+
+            if (! $artwork instanceof Artwork) {
+                return;
+            }
+
+            $this->processArtworkSafely(
+                collect([$artwork]),
+                $modelVersion,
+                $vectorEnabled,
+                $resultLimit,
+                $maxPerAuthor,
+                $minCatsTop12,
+                $weights,
+            );
+
+            return;
         }
 
-        $query->chunkById($this->batchSize, function ($artworks) use (
-            $modelVersion, $vectorEnabled, $resultLimit, $maxPerAuthor, $minCatsTop12, $weights
-        ) {
-            foreach ($artworks as $artwork) {
-                try {
-                    $this->processArtwork(
-                        $artwork, $modelVersion, $vectorEnabled, $resultLimit,
-                        $maxPerAuthor, $minCatsTop12, $weights
-                    );
-                } catch (\Throwable $e) {
-                    Log::warning("[RecComputeSimilarHybrid] Failed for artwork {$artwork->id}: {$e->getMessage()}");
-                }
+        Artwork::query()
+            ->public()
+            ->published()
+            ->select('id', 'user_id')
+            ->chunkById($this->batchSize, function ($artworks) use (
+                $modelVersion, $vectorEnabled, $resultLimit, $maxPerAuthor, $minCatsTop12, $weights
+            ) {
+                $this->processArtworkSafely(
+                    $artworks,
+                    $modelVersion,
+                    $vectorEnabled,
+                    $resultLimit,
+                    $maxPerAuthor,
+                    $minCatsTop12,
+                    $weights,
+                );
+            });
+    }
+
+    public function failed(\Throwable $exception): void
+    {
+        Log::error('[RecComputeSimilarHybrid] Job failed permanently.', [
+            'artwork_id' => $this->artworkId,
+            'batch_size' => $this->batchSize,
+            'attempts' => $this->attempts(),
+            'exception_class' => $exception::class,
+            'exception_message' => $exception->getMessage(),
+        ]);
+    }
+
+    /**
+     * @param  iterable<Artwork>  $artworks
+     */
+    private function processArtworkSafely(
+        iterable $artworks,
+        string $modelVersion,
+        bool $vectorEnabled,
+        int $resultLimit,
+        int $maxPerAuthor,
+        int $minCatsTop12,
+        array $weights,
+    ): void {
+        foreach ($artworks as $artwork) {
+            try {
+                $this->processArtwork(
+                    $artwork,
+                    $modelVersion,
+                    $vectorEnabled,
+                    $resultLimit,
+                    $maxPerAuthor,
+                    $minCatsTop12,
+                    $weights,
+                );
+            } catch (\Throwable $e) {
+                Log::warning("[RecComputeSimilarHybrid] Failed for artwork {$artwork->id}: {$e->getMessage()}", [
+                    'artwork_id' => $artwork->id,
+                    'exception_class' => $e::class,
+                ]);
             }
-        });
+        }
     }
 
     private function processArtwork(