Fix: remove Academy families from sitemaps; show total prompts in Academy prompt library; fix void closure in AcademyAdminController

app/Http/Controllers/Settings/AcademyAdminController.php

@@ -78,6 +78,7 @@ final class AcademyAdminController extends Controller
                 'challenges' => route('admin.academy.challenges.index'),
                 'submissions' => route('admin.academy.submissions.index'),
                 'badges' => route('admin.academy.badges.index'),
+                'analytics' => route('admin.academy.analytics.overview'),
             ],
         ]);
     }
@@ -1812,6 +1813,7 @@ final class AcademyAdminController extends Controller
             ->map(function ($note): ?array {
                 if (is_string($note)) {
                     $normalized = [
+                        'display_type' => '',
                         'provider' => '',
                         'model_name' => '',
                         'notes' => trim($note),
@@ -1833,6 +1835,7 @@ final class AcademyAdminController extends Controller
                 }
 
                 $normalized = [
+                    'display_type' => trim((string) ($note['display_type'] ?? '')),
                     'provider' => trim((string) ($note['provider'] ?? '')),
                     'model_name' => trim((string) ($note['model_name'] ?? '')),
                     'notes' => trim((string) ($note['notes'] ?? '')),
@@ -1847,6 +1850,7 @@ final class AcademyAdminController extends Controller
                 ];
 
                 $hasContent = collect([
+                    $normalized['display_type'],
                     $normalized['provider'],
                     $normalized['model_name'],
                     $normalized['notes'],
@@ -1890,7 +1894,9 @@ final class AcademyAdminController extends Controller
 
         $previousPaths
             ->reject(fn (string $path): bool => in_array($path, $nextPaths, true))
-            ->each(fn (string $path): bool => $this->deleteStoredLessonMediaIfLocal($path));
+            ->each(function (string $path): void {
+                $this->deleteStoredLessonMediaIfLocal($path);
+            });
     }
 
     private function promptPreviewImageUpload(UpsertAcademyPromptTemplateRequest $request): ?UploadedFile