Add unit tests, dedupe FFmpeg output filtering, harden settings records
Implements the suggestions from the last review pass:
- Add AmiReel.Tests (MSTest), covering the pure logic in Models/ and
Services/: SupportedVideoFormats, AppSettings normalization,
UserFacingErrors.Summarize, the new FfmpegProgressParser/
FfmpegOutputFilter, RenderPipeline.Validate, BuildProgressMessage, and
MoveSourceVideos. 59 tests, all passing. UI code-behind and anything that
spawns an actual FFmpeg process are left to manual/integration testing.
Exclude AmiReel.Tests\**\*.cs from AmiReel.csproj's default item glob —
it's a subfolder of the app project now, so without the exclude the app
itself was compiling the MSTest-only test files.
- Extract the FFmpeg version/library-banner boilerplate list that
ProcessRunner (live log filter) and UserFacingErrors (error summarizer)
had each duplicated into a shared FfmpegOutputFilter.IsBoilerplateLine;
each caller keeps its own remaining context-specific checks on top.
Also extract ProcessRunner's line-parsing regexes into a standalone
FfmpegProgressParser so it's directly unit-testable without spawning a
process.
- Convert AppSettings and RenderSettings from positional record
constructors to named `required` init properties. Both records had
runs of same-typed consecutive parameters (three string timing fields
in AppSettings; three doubles then five ints in RenderSettings) that a
positional constructor would let get silently transposed at a call site
without the compiler catching it. Update the two call sites
(MainPage.xaml.cs) to object-initializer syntax.
- Add Properties/AssemblyInfo.cs with InternalsVisibleTo("AmiReel.Tests")
and make Validate/BuildProgressMessage/IsNoise internal so tests can
reach them directly instead of only through process-spawning entry
points.
- README: document `dotnet test`, and note that Package.appxmanifest's
Identity is a local-dev placeholder that needs a real publisher/cert
before MSIX distribution.
Verified: dotnet build (solution + test project) is 0 warnings/errors,
dotnet test is 59/59 passing, and the app still launches unchanged.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,70 @@
|
||||
using AmiReel.Services;
|
||||
using Microsoft.VisualStudio.TestTools.UnitTesting;
|
||||
|
||||
namespace AmiReel.Tests.Services;
|
||||
|
||||
[TestClass]
|
||||
public class FfmpegProgressParserTests
|
||||
{
|
||||
[TestMethod]
|
||||
public void Parse_WithFullProgressLine_ExtractsAllFields()
|
||||
{
|
||||
// Arrange
|
||||
const string line = "frame= 1234 fps=49.8 q=-1.0 size= 102400kB time=00:00:24.68 bitrate=33987.6kbits/s speed=0.996x";
|
||||
|
||||
// Act
|
||||
FfmpegOutputLine result = FfmpegProgressParser.Parse(line);
|
||||
|
||||
// Assert
|
||||
Assert.AreEqual(new TimeSpan(0, 0, 0, 24, 680), result.Time);
|
||||
Assert.AreEqual(1234, result.Frame);
|
||||
Assert.AreEqual(49.8, result.FramesPerSecond);
|
||||
Assert.AreEqual(0.996, result.Speed);
|
||||
}
|
||||
|
||||
[TestMethod]
|
||||
public void Parse_WithNoRecognizedFields_ReturnsAllNulls()
|
||||
{
|
||||
// Arrange
|
||||
const string line = "Metadata:";
|
||||
|
||||
// Act
|
||||
FfmpegOutputLine result = FfmpegProgressParser.Parse(line);
|
||||
|
||||
// Assert
|
||||
Assert.IsNull(result.Time);
|
||||
Assert.IsNull(result.Frame);
|
||||
Assert.IsNull(result.FramesPerSecond);
|
||||
Assert.IsNull(result.Speed);
|
||||
Assert.AreEqual(line, result.Line);
|
||||
}
|
||||
|
||||
[TestMethod]
|
||||
public void Parse_WithOnlyTimeField_ExtractsTimeAndLeavesFrameFieldsNull()
|
||||
{
|
||||
// Arrange: has a "time=" field but no matching frame=/fps=/speed=x group
|
||||
const string line = "size= 1024kB time=00:01:02.03 bitrate= 100.0kbits/s";
|
||||
|
||||
// Act
|
||||
FfmpegOutputLine result = FfmpegProgressParser.Parse(line);
|
||||
|
||||
// Assert
|
||||
Assert.AreEqual(new TimeSpan(0, 0, 1, 2, 30), result.Time);
|
||||
Assert.IsNull(result.Frame);
|
||||
Assert.IsNull(result.FramesPerSecond);
|
||||
Assert.IsNull(result.Speed);
|
||||
}
|
||||
|
||||
[TestMethod]
|
||||
public void Parse_PreservesOriginalLineText()
|
||||
{
|
||||
// Arrange
|
||||
const string line = "some arbitrary ffmpeg output";
|
||||
|
||||
// Act
|
||||
FfmpegOutputLine result = FfmpegProgressParser.Parse(line);
|
||||
|
||||
// Assert
|
||||
Assert.AreEqual(line, result.Line);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user