Code review cleanup: dead code, unused capability, accessibility gap

- Remove unused `using Microsoft.Win32;` from MainPage.xaml.cs (leftover
  from the WPF OpenFileDialog era; WinUI uses Windows.Storage.Pickers)
- Trim App.xaml.cs down to the two usings it actually needs instead of the
  full WinUI3 template boilerplate list
- Change App.MainWindowInstance to an internal setter (only MainWindow
  itself should assign it)
- Add AutomationProperties.Name to the icon-only Settings button so screen
  readers announce it (it only had a mouse tooltip before)
- Delete Assets/AppIcon.ico: unreferenced by both the manifest and code,
  the real app icon comes from ApplicationIcon (branding/AmiReel.ico) and
  AppWindow.SetIcon at runtime
- Drop the systemAIModels capability from Package.appxmanifest; the app
  doesn't call any Windows AI API, so declaring it is an unnecessary
  privilege request

Verified: dotnet build produces 0 warnings/errors, app launches unchanged.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

This commit is contained in:

Gregor Klevže

2026-08-13 14:13:22 +02:00

parent 603af17e56

commit 3de3357d23

6 changed files with 6 additions and 23 deletions

									
										MainPage.xaml.cs
									
		-1
	
												View File
												
				@@ -6,7 +6,6 @@ using AmiReel.Models;

				using AmiReel.Services;

				using Microsoft.UI.Xaml;

				using Microsoft.UI.Xaml.Controls;

				using Microsoft.Win32;

				using Windows.ApplicationModel.DataTransfer;

				using Windows.Storage;

				using Windows.Storage.Pickers;